T1325067 — PivotGrid: Field Chooser — The "Cannot read properties of undefined (reading 'isMeasure')" error occurs when dragging fields while data is loading#33103
Merged
aleksei-semikozov merged 3 commits intoDevExpress:26_1from Apr 2, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a PivotGrid Field Chooser drag-and-drop crash (Cannot read properties of undefined (reading 'isMeasure')) that can occur when fields are dragged while the underlying data is still loading, by guarding the drag-cancel decision against missing field data.
Changes:
- Extracted drag-cancel logic into a new
shouldCancelDraggingutility that safely handles an undefined field. - Updated Field Chooser drag handler to use
shouldCancelDragginginstead of directly accessingfield.isMeasure. - Added unit tests covering the new drag-cancel decision logic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/utils.ts |
Adds shouldCancelDragging to centralize and null-guard drag cancellation logic. |
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts |
Uses the new helper in onDragging to prevent field.isMeasure access on undefined. |
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/utils.test.ts |
Introduces Jest coverage for shouldCancelDragging. |
packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/utils.test.ts
Show resolved
Hide resolved
sjbur
approved these changes
Apr 2, 2026
aleksei-semikozov
added a commit
to aleksei-semikozov/DevExtreme
that referenced
this pull request
Apr 2, 2026
…undefined (reading 'isMeasure')" error occurs when dragging fields while data is loading (DevExpress#33103)
aleksei-semikozov
added a commit
to aleksei-semikozov/DevExtreme
that referenced
this pull request
Apr 2, 2026
…undefined (reading 'isMeasure')" error occurs when dragging fields while data is loading (DevExpress#33103)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.